♿(frontend) add focus trap and enter key support to remove doc modal #1531
+73
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
70956fb to
34261f1
Compare
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
34261f1 to
771de1c
Compare
|
Size Change: +186 B (0%) Total Size: 4.07 MB
|
Ovgodd
added
bug
AntoLC
reviewed
Nov 6, 2025
src/frontend/apps/impress/src/components/dropdown-menu/DropdownMenu.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/components/ModalRemoveDoc.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/components/ModalRemoveDoc.tsx
Show resolved
Hide resolved
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
771de1c to
058ce45
Compare
AntoLC
approved these changes
Nov 13, 2025
Comment on lines
97
to
107
| <Box ref={cancelButtonRef}> | ||
| <Button | ||
| aria-label={t('Cancel the deletion')} | ||
| color="secondary" | ||
| fullWidth | ||
| onClick={handleClose} | ||
| onKeyDown={handleCloseKeyDown} | ||
| > | ||
| {t('Cancel')} | ||
| </Button> | ||
| </Box> |
Collaborator
There was a problem hiding this comment.
As talk together, let's put the ref directly on the Button component.
CHANGELOG.md
Outdated
| - 🐛(backend) fix trashbin list | ||
| - ♿(frontend) improve accessibility: | ||
| - ♿(frontend) remove empty alt on logo due to Axe a11y error #1516 | ||
| - ♿(frontend) add focus trap and enter key support to remove doc modal #1531 |
Collaborator
There was a problem hiding this comment.
Should be under "Unreleased".
Collaborator
Author
There was a problem hiding this comment.
ye, this is the case
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
2 times, most recently
from
7a370d0 to
ca6a814
Compare
improves a11y by enabling keyboard-triggered modal with proper focus trap Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-modal-remove-doc-focus-trap
branch
from
ca6a814 to
6314cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility and keyboard interactions for remove modal component
issue : 1530
Proposal
ModalRemoveDocuseKeyboardActionhook for Enter/Space handlers